[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 1 08:11:58 PDT 2018


jkorous added inline comments.


================
Comment at: Sema/SemaDecl.cpp:4651-4653
+
+      DeclContext *OwnerScope = Owner->getRedeclContext();
+
----------------
vsapsai wrote:
> I think the code style favours avoiding excessive vertical whitespace and I don't feel like this statement is semantically far enough from the surrounding code to be separated from it. I haven't found a specific [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html) rule, so in this case it is my personal opinion and actual formatting decision is up to you.
> 
> Other than that I have no other comments.
Strange, looks like phab lost my comment which basically was: "No problem, I see what you mean. Will remove those blank lines."


https://reviews.llvm.org/D45884





More information about the cfe-commits mailing list