[PATCH] D46019: [ASTImporter] Fix isa cast assert

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 25 02:19:50 PDT 2018


martong added a comment.

Hi Aleksei,

Thanks for the review.

We faced this assert during the CTU analysis of protobuf. We tried hard to synthesize a minimal test example both by hand and by executing creduce on multiple files. Unfortunately, we were unable to reduce to such a minimal example, yet. Nevertheless, this fix solved the problem in protobuf.

`E->getFoundDecl().getDecl()` can be null when a member expression does not involve lookup. (Note, it may involve a lookup in case of a using directive which refers to a member function in a base class template.)

I hoped that this patch could be accepted without tests, since it is very small and the changes are pretty straight forward, so I thought it can be easily verified by a review.


Repository:
  rC Clang

https://reviews.llvm.org/D46019





More information about the cfe-commits mailing list