[PATCH] D46019: [ASTImporter] Fix isa cast assert

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 25 04:03:57 PDT 2018


a.sidorin added a comment.

> `E->getFoundDecl().getDecl()` can be null when a member expression does not involve lookup. (Note, it may involve a lookup in case of a using directive which refers to a member function in a base class template.)

Yes, a pretty weird example. Unfortunately, they are pretty common for XTU.

> I hoped that this patch could be accepted without tests, since it is very small and the changes are pretty straight forward, so I thought it can be easily verified by a review.

Yes, this is the reason why I have accepted it initially.
I think we can accept this patch without a test but I'd like to get a somebody else's review. @xazax.hun, @szepet, could you take a look?
@martong Could you include the reason why this patch lacks tests into the commit message (including description of the situation where the code fails)?


Repository:
  rC Clang

https://reviews.llvm.org/D46019





More information about the cfe-commits mailing list