[PATCH] D41764: [libcxx] [cmake] Add a config option LIBCXX_HAS_WIN32_THREADS for enforcing win32 threads

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 5 07:17:46 PST 2018

mstorsjo added a comment.

In https://reviews.llvm.org/D41764#968318, @smeenai wrote:

> I think `LIBCXX_HAS_WIN32_THREAD_API` would be more consistent with the existing configuration define names?

That sounds good to me too. I can update the patch later, or before committing if it's otherwise ok.

Comment at: CMakeLists.txt:277
+    message(FATAL_ERROR "LIBCXX_HAS_WIN32_THREADS can only be set to ON"
smeenai wrote:
> The inconsistent usage of `if(` vs `if (` in this file is annoying me haha. Not this diff's fault of course, but still.
Oh, yes... The new lines here were copypasted from the pthread ones a bit further above, explaining the inconsistency.

  rCXX libc++


More information about the cfe-commits mailing list