[PATCH] D41764: [libcxx] [cmake] Add a config option LIBCXX_HAS_WIN32_THREADS for enforcing win32 threads

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 5 05:45:54 PST 2018

smeenai added a comment.

I think `LIBCXX_HAS_WIN32_THREAD_API` would be more consistent with the existing configuration define names?

Comment at: CMakeLists.txt:277
+    message(FATAL_ERROR "LIBCXX_HAS_WIN32_THREADS can only be set to ON"
The inconsistent usage of `if(` vs `if (` in this file is annoying me haha. Not this diff's fault of course, but still.

  rCXX libc++


More information about the cfe-commits mailing list