[PATCH] D41425: [darwin][driver] Warn about mismatching -<os>-version-min rather than superfluous -<os>-version-min compiler option
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 19 18:10:46 PST 2017
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+ ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+ VersionTuple(TargetMajor, TargetMinor, TargetMicro) !=
> HadExtra is not ok right? macos10.11.0.1 is not the same as macos10.11.0?
> Or HadExtra is an error somewhere else already?
Right, it would be nice to check the extra stuff too. I will commit with the check and a test for the extra part.
More information about the cfe-commits