[PATCH] D41425: [darwin][driver] Warn about mismatching -<os>-version-min rather than superfluous -<os>-version-min compiler option

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 18:07:46 PST 2017

steven_wu accepted this revision.
steven_wu added a comment.

Just a small suggestion. Looks good otherwise.

Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+           Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+                                     ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+           VersionTuple(TargetMajor, TargetMinor, TargetMicro) !=
HadExtra is not ok right? macos10.11.0.1 is not the same as macos10.11.0?
Or HadExtra is an error somewhere else already?

  rC Clang


More information about the cfe-commits mailing list