[PATCH] D39050: Add index-while-building support to Clang

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 19 15:08:23 PST 2017

ioeric added inline comments.

Comment at: include/clang/Index/IndexUnitDataConsumer.h:1
+//===--- IndexUnitDataConsumer.h - Abstract index unit data consumer ---------------===//
ioeric wrote:
> IIUC, this is the index data for a translation unit, as opposed to an AST. If so, consider calling this `UnitIndexDataConsumer` to match `(AST)IndexDataConsumer` which is parallel to this. We might want to rename them to be either `index::UnitDataConsumer` vs `index::ASTDataConsumer` or `index::UnitIndexDataConsumer` vs `index::ASTIndexDataConsumer` . I am inclined to the first pair as `index` is already implied in the namespace.
Sorry, asking you to also rename `IndexDataConsumer` is probably too much and out of the scope of this patch. I'm fine with `UnitIndexDataConsumer` or `UnitDataConsumer` or something similar for now without touching  `IndexDataConsumer` :)


More information about the cfe-commits mailing list