[PATCH] D41318: Start setting dso_local in clang

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 18 14:07:51 PST 2017


rnk added inline comments.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:690-692
+  // Only handle ELF for now.
+  if (!CGM.getTriple().isOSBinFormatELF())
+    return false;
----------------
Handling COFF here is probably trivial. Everything is dso_local unless it's dllimport. Does that matter, or is dso_local intended to be an ELF-specific annotation?


https://reviews.llvm.org/D41318





More information about the cfe-commits mailing list