[PATCH] D41149: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920)

[Vedant Kumar via Phabricator via cfe-commits]

vsk marked an inline comment as done.
vsk added a comment.

Thanks for the review!



================
Comment at: lib/CodeGen/CGBuiltin.cpp:912
+      auto IntMax =
+          llvm::APInt::getMaxValue(ResultInfo.Width).zextOrSelf(Op1Info.Width);
+      llvm::Value *TruncOverflow = CGF.Builder.CreateICmpUGT(
----------------
efriedma wrote:
> zext() rather than zextOrSelf().
Will fix before committing.


https://reviews.llvm.org/D41149