[PATCH] D41149: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920)

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 15 17:19:58 PST 2017


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/CGBuiltin.cpp:912
+      auto IntMax =
+          llvm::APInt::getMaxValue(ResultInfo.Width).zextOrSelf(Op1Info.Width);
+      llvm::Value *TruncOverflow = CGF.Builder.CreateICmpUGT(
----------------
zext() rather than zextOrSelf().


https://reviews.llvm.org/D41149





More information about the cfe-commits mailing list