[PATCH] D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 02:11:51 PST 2017

klimek accepted this revision.
klimek added a comment.


Comment at: lib/Tooling/CompilationDatabase.cpp:312
+FixedCompilationDatabase::loadFromFile(StringRef Path, std::string &ErrorMsg) {
+  ErrorMsg.clear();
+  llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> File =
sammccall wrote:
> klimek wrote:
> > I assume we can't use ErrorOr as return value?
> Again this mirrors JSONCompilationDatabase. (And also CompilationDatabasePlugin, which is harder to change)
> Change this one, change both, or leave as-is?
I think we want to add a FIXME to change the interface.


More information about the cfe-commits mailing list