[PATCH] D39799: [Tooling] Use FixedCompilationDatabase when `compile_flags.txt` is found.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 9 01:43:30 PST 2017

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D39799#920195, @sammccall wrote:

> It's doable, but then you're fighting the infrastructure here. The same ambiguity can exist between any pair of CompilationDatabasePlugins (try dumping a compile_commands.json in a google source tree). If we want to make this an error or have well-defined priority, that should be handled by autoDetectFromDirectory I think.
> (Happy to do that if you think it's important - personally I'm not convinced it will be an issue in practice)

Yeah, I'm not sure if that's an issue either. Let's see whether anyone will be using both `compile_flags.txt` and `compile_commands.json` in the first place. We can always do it later.
Oh, and LGTM from my side!


More information about the cfe-commits mailing list