[PATCH] D39676: [clangd] Add rename support.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 06:51:39 PST 2017

hokein marked an inline comment as done.
hokein added inline comments.

Comment at: clangd/ClangdServer.cpp:67
+  // Using the handle(SymbolOccurrences) from parent class.
+  using tooling::RefactoringResultConsumer::handle;
sammccall wrote:
> why is this needed? shouldn't inheriting the base method be enough if it's only ever called through the base?
We need this to make compiler happy, otherwise the compiler will emit "overloaded-virtual" error (the `handle(SymbolOccurrences)` will be hidden in this class).


More information about the cfe-commits mailing list