[PATCH] D39676: [clangd] Add rename support.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 8 06:35:58 PST 2017


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/ClangdServer.cpp:67
+
+  // Using the handle(SymbolOccurrences) from parent class.
+  using tooling::RefactoringResultConsumer::handle;
----------------
why is this needed? shouldn't inheriting the base method be enough if it's only ever called through the base?


https://reviews.llvm.org/D39676





More information about the cfe-commits mailing list