[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 05:57:20 PST 2017

xazax.hun added a comment.

In https://reviews.llvm.org/D35109#916617, @NoQ wrote:

> A breakthrough with credit going to Devin: Note that whenever we're not dealing with `>`/`<`/`<=`/`>=` (but only with additive ops and `==` and `!=`, and we have everything of the same type) we can rearrange regardless of constraints, simply because Z/nZ is an abelian group.
> First of all, it means that we definitely do not need to check constraints in those cases.

Does this mean it might be efficient enough that we want to implement this regardless what will be the final solution for the iterator checkers? Or we need a strong use case to accept such a change into core?


More information about the cfe-commits mailing list