[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 6 05:54:01 PST 2017

baloghadamsoftware added a comment.

In https://reviews.llvm.org/D35109#916648, @NoQ wrote:

> > How to find the N if we only use == or !=?
> Hence the difference between `==` and `is-the-same-symbol-as`. We can find `N` by looking at the symbol.

Sorry, if I misunderstand something, but if I do not know the `N` and have to look it up then I have to create a difference manually (as I did it originally) to look it up.

> We'd lose track of cases where, say, `i` and `.end()` were compared to each other for `>`/`<` before. The question is about how common such cases are.

`i` and `.begin()` are compared to each other for `<`. And (as I mentioned) there will be lots of `<`, `<=`, `>` and `<=` operators when invalidating.


More information about the cfe-commits mailing list