[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 25 16:23:37 PDT 2017

vsapsai added inline comments.

Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095
+    fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType();
+  }
rjmccall wrote:
> vsapsai wrote:
> > rjmccall wrote:
> > > You can't just use isa<> here; there can be typedefs of incomplete array type.
> > Thanks for catching it.
> Oh, and C allows you to have incomplete arrays of array type, e.g. int x[][4];
Right, thanks. I've checked only that `int x[][];` isn't accepted but forgot about mixing different arrays.


More information about the cfe-commits mailing list