[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 23 15:45:18 PDT 2017


rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095
+    fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType();
+  }
+
----------------
vsapsai wrote:
> rjmccall wrote:
> > You can't just use isa<> here; there can be typedefs of incomplete array type.
> Thanks for catching it.
Oh, and C allows you to have incomplete arrays of array type, e.g. int x[][4];


https://reviews.llvm.org/D38774





More information about the cfe-commits mailing list