[PATCH] D36824: [mips] Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 06:32:04 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with comment addressed.



================
Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:328
+mips::IEEE754Standard mips::getIEEE754Standard(StringRef &CPU) {
+  // Strictly speaking, mips32r2 and mips64r2 are not in accordance to standard
+  // from 2008, it was first introduced in Release 3. However, other compilers 
----------------
"are not in accordance to standard from 2008, it was first introduced in Release 3."

This should read:

"do not conform to the IEEE754-2008 standard. Support for this standard was first introduced in Release 3."


Repository:
  rL LLVM

https://reviews.llvm.org/D36824





More information about the cfe-commits mailing list