[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 14:11:03 PDT 2017


erichkeane created this revision.
Herald added subscribers: kbarton, aheejin, fedor.sergeev, jgravelle-google, krytarowski, sbc100, javed.absar, mgorny, nhaehnle, nemanjai, sdardis, jyknight, dschuff, srhines, jfb, jholewinski.

Targets.cpp is getting unwieldy, and even minor changes cause the entire thing to cause recompilation for everyone.  This patch bites the bullet and breaks it up into a number of files.

I tended to keep function definitions in the class declaration unless it caused additional includes to be necessary.  In those cases, I pulled it over into the .cpp file.  Content is copy/paste for the most part, besides includes/format/etc.


https://reviews.llvm.org/D35701

Files:
  lib/Basic/CMakeLists.txt
  lib/Basic/Targets.cpp
  lib/Basic/Targets.h
  lib/Basic/Targets/AArch64.cpp
  lib/Basic/Targets/AArch64.h
  lib/Basic/Targets/AMDGPU.cpp
  lib/Basic/Targets/AMDGPU.h
  lib/Basic/Targets/ARM.cpp
  lib/Basic/Targets/ARM.h
  lib/Basic/Targets/AVR.cpp
  lib/Basic/Targets/AVR.h
  lib/Basic/Targets/BPF.cpp
  lib/Basic/Targets/BPF.h
  lib/Basic/Targets/Hexagon.cpp
  lib/Basic/Targets/Hexagon.h
  lib/Basic/Targets/Lanai.cpp
  lib/Basic/Targets/Lanai.h
  lib/Basic/Targets/Le64.cpp
  lib/Basic/Targets/Le64.h
  lib/Basic/Targets/MSP430.cpp
  lib/Basic/Targets/MSP430.h
  lib/Basic/Targets/Mips.cpp
  lib/Basic/Targets/Mips.h
  lib/Basic/Targets/NVPTX.cpp
  lib/Basic/Targets/NVPTX.h
  lib/Basic/Targets/Nios2.cpp
  lib/Basic/Targets/Nios2.h
  lib/Basic/Targets/OSTargets.cpp
  lib/Basic/Targets/OSTargets.h
  lib/Basic/Targets/PNaCl.cpp
  lib/Basic/Targets/PNaCl.h
  lib/Basic/Targets/PPC.cpp
  lib/Basic/Targets/PPC.h
  lib/Basic/Targets/SPIR.cpp
  lib/Basic/Targets/SPIR.h
  lib/Basic/Targets/Sparc.cpp
  lib/Basic/Targets/Sparc.h
  lib/Basic/Targets/SystemZ.cpp
  lib/Basic/Targets/SystemZ.h
  lib/Basic/Targets/TCE.cpp
  lib/Basic/Targets/TCE.h
  lib/Basic/Targets/WebAssembly.cpp
  lib/Basic/Targets/WebAssembly.h
  lib/Basic/Targets/X86.cpp
  lib/Basic/Targets/X86.h
  lib/Basic/Targets/XCore.cpp
  lib/Basic/Targets/XCore.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35701.107581.patch
Type: text/x-patch
Size: 734437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170720/88b6757b/attachment-0001.bin>


More information about the cfe-commits mailing list