[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

Tim Northover via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 14:27:02 PDT 2017

t.p.northover added a comment.

> I tended to keep function definitions in the class declaration unless it caused additional includes to be necessary.

Was that for implementation simplicity, or part of some cunning design goal? A lot of these pairs look pretty header-heavy to me (especially given that we're overriding virtual functions so inlining is mostly impossible).


More information about the cfe-commits mailing list