[PATCH] D33082: Fix Libc++ build with MinGW64

Martell Malone via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 26 06:57:16 PDT 2017

martell added a comment.

LGTM but I can't speak for the area where you added `#include <cstdio>` and killed off the `_NEWLIB_VERSION` check
Seems in order based on https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html
Maybe make a note of the minimum newlib version supported somewhere?

Others may have more specific thoughts on the diff.


More information about the cfe-commits mailing list