[PATCH] D33082: Fix Libc++ build with MinGW64

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 26 10:27:48 PDT 2017

EricWF added a comment.

In https://reviews.llvm.org/D33082#765644, @martell wrote:

> LGTM but I can't speak for the area where you added `#include <cstdio>` and killed off the `_NEWLIB_VERSION` check
>  Seems in order based on https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html
>  Maybe make a note of the minimum newlib version supported somewhere?

I removed the section you're referring to because it's unneeded. `<__locale>` does the exact same `#include` dance. and `<locale>` includes `<__locale>`.
It should not have an affect on functionality.


More information about the cfe-commits mailing list