[PATCH] D32988: [libc++] Refactor Windows support headers.

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 09:12:33 PDT 2017

bcraig added inline comments.

Comment at: include/__config:232-235
+#ifndef NOMINMAX
+#define NOMINMAX
I can see this helping when we are build libc++, but I don't think it helps client apps.  They could have included windows.h before including our headers.

Don't get me wrong, I dislike the min and max macros, and bear no hard feelings towards people that define this project wide on the command line, I'm just not sure it will get things done right here.

In the past, I've just surrounded my min and max declarations with parenthesis to suppress macro expansion.


More information about the cfe-commits mailing list