[PATCH] D32988: [libc++] Refactor Windows support headers.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 21:09:29 PDT 2017


EricWF planned changes to this revision.
EricWF added a comment.

This breaks MinGW. I'll update soon.



================
Comment at: include/algorithm:647
 #endif
-#if defined(_LIBCPP_MSVCRT) || defined(__MINGW32__)
-#include "support/win32/support.h"
+#if defined(_LIBCPP_COMPILER_MSVC)
+#include "support/win32/msvc_builtin_support.h"
----------------
This change is incorrect too.


================
Comment at: include/limits:114
 
-#if defined(_LIBCPP_MSVCRT)
-#include "support/win32/limits_win32.h"
+#if defined(_LIBCPP_COMPILER_MSVC)
+#include "support/win32/limits_msvc_win32.h"
----------------
This is incorrect for MinGW.


https://reviews.llvm.org/D32988





More information about the cfe-commits mailing list