[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

[Dimitry Andric via Phabricator via cfe-commits]

dim added a comment.

In https://reviews.llvm.org/D28520#656202, @delesley wrote:

> The big question for me is whether these functions are exposed as part of the public libcxx API, or whether they are only used internally.


As far as I can see, they are only used internally, in `src/algorithm.cpp` and `src/mutex.cpp`.  Of course they aren't "hidden" in any way in the `include/__thread_support` header, but obviously functions starting with double underscores are not meant as a public API.

> If they are only used internally, then no_thread_safety_analysis is probably the correct option.  (Unless, of course, the libcxx developers want to start using the analysis themselves, but I suspect they don't.)

Yes, and since @EricWF also prefers this, I going to switch this review back to the previous form again.


https://reviews.llvm.org/D28520