[PATCH] D28520: Disable -Wthread-safety-analysis for some functions in __thread_support

[Delesley Hutchins via Phabricator via cfe-commits]

delesley added a comment.

The big question for me is whether these functions are exposed as part of the public libcxx API, or whether they are only used internally.  (Again, I'm not a libcxx expert.)  If they are part of the public API, then users may want to switch them on and off in their own code.  In that case, I'm happy with the current variant.

If they are only used internally, then no_thread_safety_analysis is probably the correct option.  (Unless, of course, the libcxx developers want to start using the analysis themselves, but I suspect they don't.)


https://reviews.llvm.org/D28520