[PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 16 09:43:10 PST 2017

Looks like Ben signed off on this on Phab - but the email didn't go to the
list (making this look like code was sent for review, then committed,
without review/approval happening)

Ben: I think Phab doesn't send mail for an approval with no text, so at
least as a workaround you can write something in the comments section when
approving (people often write "LGTM" or similar) to ensure the approval is
reflected on the mailing list.

On Wed, Jan 11, 2017 at 1:59 AM Manuel Klimek via Phabricator via
cfe-commits <cfe-commits at lists.llvm.org> wrote:

> klimek created this revision.
> klimek added a reviewer: bkramer.
> klimek added a subscriber: cfe-commits.
> Instead of just using popularity, we also take into account how similar the
> path of the current file is to the path of the header.
> Our first approach is to get popularity into a reasonably small scale by
> taking
> log2 (which is roughly intuitive to how humans would bucket popularity),
> and
> multiply that with the number of matching prefix path fragments of the
> included
> header with the current file.
> Note that currently we do not take special care for unclean paths
> containing
> "../" or "./".
> https://reviews.llvm.org/D28548
> Files:
>   include-fixer/IncludeFixer.cpp
>   include-fixer/SymbolIndexManager.cpp
>   include-fixer/SymbolIndexManager.h
>   include-fixer/tool/ClangIncludeFixer.cpp
>   test/include-fixer/Inputs/fake_yaml_db.yaml
>   test/include-fixer/ranking.cpp
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170116/bb23ae3c/attachment.html>

More information about the cfe-commits mailing list