<div dir="ltr">Looks like Ben signed off on this on Phab - but the email didn't go to the list (making this look like code was sent for review, then committed, without review/approval happening)<br><br>Ben: I think Phab doesn't send mail for an approval with no text, so at least as a workaround you can write something in the comments section when approving (people often write "LGTM" or similar) to ensure the approval is reflected on the mailing list.<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 11, 2017 at 1:59 AM Manuel Klimek via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">klimek created this revision.<br class="gmail_msg">
klimek added a reviewer: bkramer.<br class="gmail_msg">
klimek added a subscriber: cfe-commits.<br class="gmail_msg">
<br class="gmail_msg">
Instead of just using popularity, we also take into account how similar the<br class="gmail_msg">
path of the current file is to the path of the header.<br class="gmail_msg">
Our first approach is to get popularity into a reasonably small scale by taking<br class="gmail_msg">
log2 (which is roughly intuitive to how humans would bucket popularity), and<br class="gmail_msg">
multiply that with the number of matching prefix path fragments of the included<br class="gmail_msg">
header with the current file.<br class="gmail_msg">
Note that currently we do not take special care for unclean paths containing<br class="gmail_msg">
"../" or "./".<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D28548" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28548</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  include-fixer/IncludeFixer.cpp<br class="gmail_msg">
  include-fixer/SymbolIndexManager.cpp<br class="gmail_msg">
  include-fixer/SymbolIndexManager.h<br class="gmail_msg">
  include-fixer/tool/ClangIncludeFixer.cpp<br class="gmail_msg">
  test/include-fixer/Inputs/fake_yaml_db.yaml<br class="gmail_msg">
  test/include-fixer/ranking.cpp<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div></div>