[PATCH] D28725: [libc++][CMake] Use debug MSVC runtimes when libc++ is built in debug mode

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 23:36:43 PST 2017

smeenai added inline comments.

Comment at: CMakeLists.txt:394
 # non-debug DLLs
 remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
EricWF wrote:
> smeenai wrote:
> > We should be able to remove this now, right?
> I would still rather strip it and re-add it. Just incase it gets added by LLVM or another parent project.
Not completely sure I understand. Isn't this gonna be coming from cmake itself?


More information about the cfe-commits mailing list