[PATCH] D28725: [libc++][CMake] Use debug MSVC runtimes when libc++ is built in debug mode

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 13 23:33:07 PST 2017

EricWF added a comment.

In https://reviews.llvm.org/D28725#646325, @smeenai wrote:

> Awesome. LGTM except that force-removing the `_DEBUG` define and then linking against the debug libraries might cause some wonkiness.

Ack. I'll update the patch to still force remove `_DEBUG` but then later re-add it under the correct circumstances.

Comment at: CMakeLists.txt:394
 # non-debug DLLs
 remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
smeenai wrote:
> We should be able to remove this now, right?
I would still rather strip it and re-add it. Just incase it gets added by LLVM or another parent project.


More information about the cfe-commits mailing list