[PATCH] D28343: [AVR] Fix register numbers for in getGCCAddlRegNames()

Dylan McKay via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 23:25:19 PST 2017


I see, that's a good idea.

I'll revert r291083 and we can go forward with this patch.

On Thu, Jan 5, 2017 at 8:05 PM, Senthil Kumar Selvaraj via Phabricator <
reviews at reviews.llvm.org> wrote:

> saaadhu added a comment.
>
> If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames
> array at all,
>
> The reason I had them in AddlRegNames was to tell Clang that they alias
> regs in GCCRegNames.  I followed X86TargetInfo's example - it has "ax" in
> GCCRegNames, and "al", "ah", "eax" and "rax" in AddlRegNames. I figured
> Clang could potentially use the fact that they alias when analyzing inline
> asm to detect unintended clobbers.
>
>
> https://reviews.llvm.org/D28343
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170105/932bf064/attachment.html>


More information about the cfe-commits mailing list