[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead
Eric van Gyzen via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 23 07:29:12 PST 2016
vangyzen added a comment.
In https://reviews.llvm.org/D26979#604013, @EricWF wrote:
> Nope. Feel free to commit after adding the requested assertions.
I would gladly commit it, but I don't have commit access. I'm quite new here.
Comment at: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65
+ expected = *std::localeconv()->thousands_sep;
+ (void) std::setlocale(LC_NUMERIC, "C");
> We should probably assert that `thousands_sep` isn't a multibyte character.
I don't quite follow. C defines it as `char*`. Are you concerned about an implementation defining it as `wchar_t*`?
More information about the cfe-commits