[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 23 01:58:46 PST 2016

EricWF added a comment.

In https://reviews.llvm.org/D26979#603110, @vangyzen wrote:

> @EricWF, would you like to see anything more from me?  I could set up an LLVM development environment on my Mac if you want me to run the unit tests on Mac.

Nope. Feel free to commit after adding the requested assertions.

Comment at: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65
+        {
+            expected = *std::localeconv()->thousands_sep;
+            (void) std::setlocale(LC_NUMERIC, "C");
We should probably assert that `thousands_sep` isn't a multibyte character.


More information about the cfe-commits mailing list