[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

Malcolm Parsons via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 15 13:54:28 PST 2016


malcolm.parsons added a comment.

In https://reviews.llvm.org/D26453#596254, @aaron.ballman wrote:

> (This part of the check is one half modernization, one half performance, and one half correctness, depending on which lens you view the code through.)


The performance part should be handled by performance-unnecessary-value-param.
It should warn in this situation, but not create a fix that would conflict with modernize-pass-by-value's fix.


https://reviews.llvm.org/D26453





More information about the cfe-commits mailing list