[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

[Aaron Ballman via cfe-commits]

aaron.ballman added a comment.

I think this meets my needs for the cert-oop11-cpp check as it appears to be preserving the original behavior. If a user has the `UseCERTSemantics` option set in one of their scripts, that appears to be silently accepted and discarded currently, so I don't think this will break anyone's build scripts.

The downside has more to do with the categorization. Not everyone enables "modernize", which is now the only place to be told about a possible correctness issue that misc-move-constructor-init was previously reporting. (This part of the check is one half modernization, one half performance, and one half correctness, depending on which lens you view the code through.) I don't think that's a huge downside, however.

This change should definitely be called out in the release notes.


https://reviews.llvm.org/D26453