[PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

Joerg Sonnenberger via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 1 09:34:51 PDT 2016

On Fri, Sep 30, 2016 at 03:41:53PM -0700, Richard Trieu via cfe-commits wrote:
> Currently, this warning is on by default.  As you said, the results you
> found look intentional in many cases, so there is a high false positive
> rate.  For on by default warnings, we expect a high true positive rate and
> intend for users to not disable the warning.  From my analysis on a
> separate codebase, I found less than 10% true positive rate out of 200
> warnings.  One option might be to move this warning to a subgroup, which
> would leave it discoverable from either -Wall or -Wparentheses, but not
> have it on by default.

We are now only talking about the right shift version, are we? That
seems to me to be much less intrusive, but should belong into the same
subgroup as the add checks.


More information about the cfe-commits mailing list