[PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators

Richard Trieu via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 15:41:53 PDT 2016

Currently, this warning is on by default.  As you said, the results you
found look intentional in many cases, so there is a high false positive
rate.  For on by default warnings, we expect a high true positive rate and
intend for users to not disable the warning.  From my analysis on a
separate codebase, I found less than 10% true positive rate out of 200
warnings.  One option might be to move this warning to a subgroup, which
would leave it discoverable from either -Wall or -Wparentheses, but not
have it on by default.

On Wed, Sep 28, 2016 at 4:09 AM, Daniel Marjamäki <
daniel.marjamaki at evidente.se> wrote:

> danielmarjamaki added a comment.
> I updated the patch so it does not warn about 'A * B << C'. It's a simple
> fix. I have not made careful measurements but I guess that the performance
> penalty is acceptable.
> https://reviews.llvm.org/D24861
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/b0128c18/attachment.html>

More information about the cfe-commits mailing list