[PATCH] D24809: [libcxx] [cmake] Strip possibly-inherited compiler flags in in-tree build only

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 27 01:03:45 PDT 2016

mgorny marked an inline comment as done.
mgorny added a comment.

Thanks for the review. Tested and committing now.

Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
-             -stdlib=libc++ -stdlib=libstdc++ -lc++abi -m32)
+  # Remove flags that may have snuck in.
EricWF wrote:
> We always want to strip `-stdlib=<foo>` because it's just nonsense to enable the STL while building the STL.
Ok, moved it below the endif().


More information about the cfe-commits mailing list