[PATCH] D24809: [libcxx] [cmake] Strip possibly-inherited compiler flags in in-tree build only

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 26 23:59:33 PDT 2016

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM modulo inline comments.

Comment at: CMakeLists.txt:310
@@ -309,4 +309,3 @@
-# Remove flags that may have snuck in.
-remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG
-             -stdlib=libc++ -stdlib=libstdc++ -lc++abi -m32)
+  # Remove flags that may have snuck in.
We always want to strip `-stdlib=<foo>` because it's just nonsense to enable the STL while building the STL.


More information about the cfe-commits mailing list