[PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 22 07:58:00 PDT 2016

hokein added a comment.

The interfaces look good to me roughly.

Comment at: migrate-tool/MigrationEnvironment.h:22
@@ +21,3 @@
+// RefactoringManager, and AffectedFilesFinder.
+class MigrationEnvironment {
`MigrationContext` might be better?

Comment at: migrate-tool/MigrationEnvironment.h:24
@@ +23,3 @@
+  MigrationEnvironment() = delete;
+  // Creates a migration environement containing codebase-dependent component.
This is not needed IMO since you have defined a four-parameters constructor below, compiler won't generate the default constructor implicitly.


More information about the cfe-commits mailing list