[PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 19 10:34:06 PDT 2016

ioeric added a comment.

In https://reviews.llvm.org/D24380#544720, @hokein wrote:

> Sorry for the delay. 
>  The patch only contains an unittest for `HeaderGenerato`r, which is not quite enough. Should we create a fake migrate-tool binary to illustrate APIs usage?


Good idea. I wanted to add a dummy tool once the interfaces are stable. But I guess now is the right time.

Comment at: migrate-tool/MigrateTool.h:50
@@ +49,3 @@
+  public:
+    enum class MigrateType {
+      Class,
hokein wrote:
> What is the 'MigrateType' used for? I can't find any usage in the patch.
Deleted it for now. Will add it when it is actually used in the future.


More information about the cfe-commits mailing list