[PATCH] D24314: [libc++] Clean up MSVC support

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 7 14:08:20 PDT 2016

smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.

Visual Studio 2013 (CRT version 12) added support for many C99 long long
and long double functions. Visual Studio 2015 (CRT version 14) increased
C99 and C11 compliance further. Since we don't support Visual Studio
versions older than 2013, we can considerably clean up the support



Index: include/support/win32/support.h
--- include/support/win32/support.h
+++ include/support/win32/support.h
@@ -22,7 +22,7 @@
 #include <intrin.h>
 #if defined(_LIBCPP_MSVCRT)
-#include <xlocinfo.h>
+#include <crtversion.h>
 #define swprintf _snwprintf
 #define vswprintf _vsnwprintf
@@ -45,27 +45,11 @@
 #endif // __MINGW32__
 #if defined(_LIBCPP_MSVCRT)
 #define snprintf _snprintf
-#define atoll _atoi64
-#define strtoll _strtoi64
-#define strtoull _strtoui64
-#define wcstoll _wcstoi64
-#define wcstoull _wcstoui64
-_LIBCPP_ALWAYS_INLINE float strtof(const char *nptr, char **endptr)
-  return _Stof(nptr, endptr, 0);
-_LIBCPP_ALWAYS_INLINE double strtod(const char *nptr, char **endptr)
-  return _Stod(nptr, endptr, 0);
-_LIBCPP_ALWAYS_INLINE long double strtold(const char *nptr, char **endptr)
-  return _Stold(nptr, endptr, 0);
 #define _Exit _exit
 #if defined(_LIBCPP_MSVC)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24314.70593.patch
Type: text/x-patch
Size: 1046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160907/e4926b07/attachment-0001.bin>

More information about the cfe-commits mailing list