[PATCH] D24314: [libc++] Clean up MSVC support

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 7 14:11:49 PDT 2016

EricWF added a comment.

This LGTM but I'll let @compnerd give it the final OK, since I've never built libc++ on windows.

Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
 #if defined(_LIBCPP_MSVCRT)
 #define snprintf _snprintf
Maybe fold these to `#if`'s into `#if defined(_VC_CRT_MAJOR_VERSION) && _VC_CRT_MAJOR_VERSION < 14`.


More information about the cfe-commits mailing list