[PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 09:14:42 PDT 2016

alexfh added a comment.

In https://reviews.llvm.org/D23434#513839, @djasper wrote:

> I think we got confused. We once had tried to write an experimental separate check to comply with Google's style guide. If you want to fiddle around with that, contact me, I can send you pointers. But as I mentioned we moved away from that. And I think it makes more sense to re-create the sort-across-blocks functionality in clang-format and not in clang-tidy.

Yep, we definitely got confused. That experimental check actually implemented cross-block sorting, but this caused a bunch of issues. Which makes me think that proper implementation of cross-block include sorting is challenging be it in clang-format or clang-tidy. Clang-format probably makes it even more complex, since a higher safety of transformations is expected from it.


More information about the cfe-commits mailing list