[PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

Zachary Turner via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 09:10:53 PDT 2016

one disadvantage to clang format is that you have less control over how and
whether to apply fixits. Reordering across blocks has a higher risk of
breaking code, and you can't tell clang format to only apply fixits which
don't break code, or to not apply any fixits but just warn.

Code duplication is always bad, but maybe we could find a way to share code
between the two so that they share the same algorithm.

I'm not opposed to trying to add cross block reordering to clang format,
but killing the clang tidy check entirely breaks my use case, and since the
current patch is strictly a bugfix should be fine to commit it right?

On Fri, Aug 12, 2016 at 8:50 AM Daniel Jasper <djasper at google.com> wrote:

> djasper added a comment.
> I think we got confused. We once had tried to write an experimental
> separate check to comply with Google's style guide. If you want to fiddle
> around with that, contact me, I can send you pointers. But as I mentioned
> we moved away from that. And I think it makes more sense to re-create the
> sort-across-blocks functionality in clang-format and not in clang-tidy.
> https://reviews.llvm.org/D23434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160812/0d04fa4c/attachment.html>

More information about the cfe-commits mailing list