[PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

Zachary Turner via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 08:32:31 PDT 2016

You and daniel both imply that clang-tidy can sort across blocks. Am I
missing this somewhere?

My intention was to add an option for this in a followup patch because it
doesn't seem to be able to currently.
On Fri, Aug 12, 2016 at 8:21 AM Alexander Kornienko <alexfh at google.com>

> alexfh accepted this revision.
> alexfh added a comment.
> This revision is now accepted and ready to land.
> The patch LG.
> In https://reviews.llvm.org/D23434#513533, @djasper wrote:
> > I think we should entirely drop this implementation of the check and let
> it just check #includes with clang-format. clang-format's implementation
> isn't a strict superset, e.g. won't sort between multiple blocks, but
> that's intentional for now.
> Since sorting across blocks is frequently needed to make include order
> consistent with the LLVM coding standards, it makes sense to keep this
> check until clang-format is able to sort across blocks. Especially, since
> Zachary is specifically interested in this functionality.
> https://reviews.llvm.org/D23434
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160812/9bea6a9d/attachment.html>

More information about the cfe-commits mailing list