[PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 08:20:52 PDT 2016

alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

The patch LG.

In https://reviews.llvm.org/D23434#513533, @djasper wrote:

> I think we should entirely drop this implementation of the check and let it just check #includes with clang-format. clang-format's implementation isn't a strict superset, e.g. won't sort between multiple blocks, but that's intentional for now.

Since sorting across blocks is frequently needed to make include order consistent with the LLVM coding standards, it makes sense to keep this check until clang-format is able to sort across blocks. Especially, since Zachary is specifically interested in this functionality.


More information about the cfe-commits mailing list