[PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 07:13:20 PDT 2016

omtcyfz added a subscriber: omtcyfz.

Comment at: clang-tidy/modernize/DeprecatedHeadersCheck.cpp:79
@@ -69,3 +78,3 @@
     for (const auto &KeyValue :
          std::vector<std::pair<llvm::StringRef, std::string>>(
              {{"fenv.h", "cfenv"},
aaron.ballman wrote:
> This will definitely fail in MSVC 2013.
See the left side of `diff`. It already is in source tree, buildbots never complained.

Thus, it won't.

Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:39
@@ +38,3 @@
+* `<string.h>` -> `<cstring>`
+* `<tgmath.h>` -> `<ctgmath>`     // deprecated since C++11
+* `<time.h>` -> `<ctime>`
alexfh wrote:
> Not sure if "deprecated" is the right word here. The wording seems to be slightly different: "This header simply includes <cmath> and <ccomplex>."
at least http://en.cppreference.com/w/cpp/header says so...


More information about the cfe-commits mailing list